Skip to content

feat(test): add a test utils crate to make log initialization possible everywhere #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 14, 2025
Merged

feat(test): add a test utils crate to make log initialization possible everywhere #5521

merged 8 commits into from
Aug 14, 2025

Conversation

multisme
Copy link
Contributor

@multisme multisme commented Aug 12, 2025 •
edited by bnjbvr
Loading

This PR allows init_tracing_for_test to be called by any other crate in the sdk

Signed-off-by: multi [email protected]

Fixes #5292

@multisme multisme requested review from a team as code owners August 12, 2025 15:01
@multisme multisme requested review from stefanceriu and andybalaam and removed request for a team August 12, 2025 15:01
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5521 will not alter performance

Comparing multisme:feature/Solve_matrix_sk_common_not_settingg_up_a_test_tracing_subscriber (bcf77cf) with main (b3c53dd)

Summary

✅ 31 untouched benchmarks

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (1eb8f6a) to head (bcf77cf).
⚠️ Report is 20 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5521   +/-   ##
=======================================
  Coverage   88.56%   88.57%           
=======================================
  Files         340      340           
  Lines       93694    93694           
  Branches    93694    93694           
=======================================
+ Hits        82982    82988    +6     
+ Misses       6579     6573    -6     
  Partials     4133     4133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bnjbvr
bnjbvr requested changes Aug 13, 2025
View reviewed changes
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks! Can you also invoke the macro in matrix_sdk_common, to prove that it addresses the issue, please?

@bnjbvr bnjbvr changed the title Create a crate that allows the use of init_tracing_for_test par any c… feat(test): add a test utils crate to make log initialization possible everywhere Aug 13, 2025
bnjbvr
bnjbvr approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we'll also need to add it to the release scripts. Will push to your branch if I can

@bnjbvr bnjbvr enabled auto-merge (squash) August 14, 2025 05:10
@bnjbvr bnjbvr merged commit a66b2c5 into matrix-org:main Aug 14, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matrix_sdk_common doesn't set up the test tracing subscriber
2 participants
@multisme @bnjbvr